Change in ovirt-engine[master]: webadmin: Use "parseInt" in "onPanelDragDrop"

juan.hernandez at redhat.com juan.hernandez at redhat.com
Thu Sep 24 11:37:46 UTC 2015


Juan Hernandez has submitted this change and it was merged.

Change subject: webadmin: Use "parseInt" in "onPanelDragDrop"
......................................................................


webadmin: Use "parseInt" in "onPanelDragDrop"

This is needed in order to avoid the following findbugs error:

  Boxing/unboxing to parse a primitive

  A boxed primitive is created from a String, just to extract the
  unboxed primitive value. It is more efficient to just call the static
  parseXXX method.

  Bug kind and pattern: Bx - DM_BOXED_PRIMITIVE_FOR_PARSING

Change-Id: I2e1241b2ae84bb6e0d62692d9de01eb34044c46f
Signed-off-by: Juan Hernandez <juan.hernandez at redhat.com>
---
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/view/popup/numa/DragTargetScrollPanel.java
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Juan Hernandez: Verified; Passed CI tests
  Alexander Wels: Looks good to me, approved



-- 
To view, visit https://gerrit.ovirt.org/46562
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I2e1241b2ae84bb6e0d62692d9de01eb34044c46f
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Juan Hernandez <juan.hernandez at redhat.com>
Gerrit-Reviewer: Alexander Wels <awels at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Juan Hernandez <juan.hernandez at redhat.com>
Gerrit-Reviewer: automation at ovirt.org



More information about the Engine-commits mailing list