Change in ovirt-engine[master]: tools: Fix adding subscriber entries

[juan.hernandez at redhat.com]

Juan Hernandez has submitted this change and it was merged.

Change subject: tools: Fix adding subscriber entries
......................................................................


tools: Fix adding subscriber entries

This is needed in order to avoid the following findbugs warning, and it
looks like a real issue:

  Return value of method without side effect is ignored

  This code calls a method and ignores the return value. However our
  analysis shows that the method (including its implementations in
  subclasses if any) does not produce any effect other than return
  value. Thus this call can be removed.

  We are trying to reduce the false positives as much as possible, but
  in some cases this warning might be wrong. Common false-positive cases
  include:

  - The method is designed to be overridden and produce a side effect in
  other projects which are out of the scope of the analysis.
  - The method is called to trigger the class loading which may have a
  side effect.
  - The method is called just to get some exception.

  If you feel that our assumption is incorrect, you can use a
  @CheckReturnValue annotation to instruct FindBugs that ignoring the
  return value of this method is acceptable.

  Bug kind and pattern: RV - RV_RETURN_VALUE_IGNORED_NO_SIDE_EFFECT

Change-Id: I075d33096ae7a7a62d955bdec09324eec01ece6e
Signed-off-by: Juan Hernandez <juan.hernandez at redhat.com>
---
M backend/manager/tools/src/main/java/org/ovirt/engine/core/notifier/NotificationService.java
1 file changed, 4 insertions(+), 2 deletions(-)

Approvals:
  Martin Peřina: Looks good to me, but someone else must approve
  Juan Hernandez: Verified
  Jenkins CI: Passed CI tests
  Oved Ourfali: Looks good to me, approved



-- 
To view, visit https://gerrit.ovirt.org/46626
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I075d33096ae7a7a62d955bdec09324eec01ece6e
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Juan Hernandez <juan.hernandez at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Juan Hernandez <juan.hernandez at redhat.com>
Gerrit-Reviewer: Martin Peřina <mperina at redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali at redhat.com>
Gerrit-Reviewer: automation at ovirt.org