Change in ovirt-engine[master]: tools: Test config key after checking null

[juan.hernandez at redhat.com]

Juan Hernandez has submitted this change and it was merged.

Change subject: tools: Test config key after checking null
......................................................................


tools: Test config key after checking null

This is needed in order to avoid the following findbugs error:

  Nullcheck of value previously dereferenced

  A value is checked here to see whether it is null, but this value
  can't be null because it was previously dereferenced and if it were
  null a null pointer exception would have occurred at the earlier
  dereference. Essentially, this code and the previous dereference
  disagree as to whether this value is allowed to be null. Either the
  check is redundant or the previous dereference is erroneous.

  Bug kind and pattern: RCN - RCN_REDUNDANT_NULLCHECK_WOULD_HAVE_BEEN_A_NPE

Change-Id: Idd2fcf196fdefeb2c28e19b687b998ecfd45d7de
Signed-off-by: Juan Hernandez <juan.hernandez at redhat.com>
---
M backend/manager/tools/src/main/java/org/ovirt/engine/core/config/EngineConfigLogic.java
1 file changed, 1 insertion(+), 2 deletions(-)

Approvals:
  Martin Peřina: Looks good to me, but someone else must approve
  Juan Hernandez: Verified; Looks good to me, approved
  Jenkins CI: Passed CI tests



-- 
To view, visit https://gerrit.ovirt.org/46622
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Idd2fcf196fdefeb2c28e19b687b998ecfd45d7de
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Juan Hernandez <juan.hernandez at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Juan Hernandez <juan.hernandez at redhat.com>
Gerrit-Reviewer: Martin Peřina <mperina at redhat.com>
Gerrit-Reviewer: automation at ovirt.org