Change in ovirt-engine[master]: restapi: Make "AlertPanel.Type" enum fields private

[juan.hernandez at redhat.com]

Juan Hernandez has submitted this change and it was merged.

Change subject: restapi: Make "AlertPanel.Type" enum fields private
......................................................................


restapi: Make "AlertPanel.Type" enum fields private

This is needed in order to avoid the following findbugs warning:

  Enum field is public and mutable

  A mutable public field is defined inside a public enum, thus can be
  changed by malicious code or by accident from another package. Though
  mutable enum fields may be used for lazy initialization, it's a bad
  practice to expose them to the outer world. Consider declaring this
  field final and/or package-private.

  Bug kind and pattern: ME - ME_MUTABLE_ENUM_FIELD

Change-Id: Ic1d2ddf68985e020dd156900184ed8df2d1d1e15
Signed-off-by: Juan Hernandez <juan.hernandez at redhat.com>
---
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/panel/AlertPanel.java
1 file changed, 2 insertions(+), 2 deletions(-)

Approvals:
  Juan Hernandez: Verified; Passed CI tests
  Greg Sheremeta: Looks good to me, approved



-- 
To view, visit https://gerrit.ovirt.org/46558
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ic1d2ddf68985e020dd156900184ed8df2d1d1e15
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Juan Hernandez <juan.hernandez at redhat.com>
Gerrit-Reviewer: Alexander Wels <awels at redhat.com>
Gerrit-Reviewer: Greg Sheremeta <gshereme at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Juan Hernandez <juan.hernandez at redhat.com>
Gerrit-Reviewer: automation at ovirt.org