Change in ovirt-engine[master]: core: Make "Version.ALL" unmodifiable

[juan.hernandez at redhat.com]

Juan Hernandez has submitted this change and it was merged.

Change subject: core: Make "Version.ALL" unmodifiable
......................................................................


core: Make "Version.ALL" unmodifiable

This is needed in order to avoid the following findbugs warning:

  Field is a mutable collection which should be package protected

  A mutable collection instance is assigned to a final static field, thus
  can be changed by malicious code or by accident from another package.
  The field could be made package protected to avoid this vulnerability.
  Alternatively you may wrap this field into
  Collections.unmodifiableSet/List/Map/etc. to avoid this vulnerability.

  Bug kind and pattern: MS - MS_MUTABLE_COLLECTION_PKGPROTECT

Change-Id: If185a4e600c1e893229b3d7e72bf0cbed76ff58a
Signed-off-by: Juan Hernandez <juan.hernandez at redhat.com>
---
M backend/manager/modules/compat/src/main/java/org/ovirt/engine/core/compat/Version.java
1 file changed, 4 insertions(+), 1 deletion(-)

Approvals:
  Martin Peřina: Looks good to me, but someone else must approve
  Juan Hernandez: Verified; Looks good to me, approved
  Jenkins CI: Passed CI tests



-- 
To view, visit https://gerrit.ovirt.org/46616
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: If185a4e600c1e893229b3d7e72bf0cbed76ff58a
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Juan Hernandez <juan.hernandez at redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Juan Hernandez <juan.hernandez at redhat.com>
Gerrit-Reviewer: Martin Peřina <mperina at redhat.com>
Gerrit-Reviewer: automation at ovirt.org