Change in ovirt-engine[ovirt-engine-3.6]: restapi: Fix condition in "IconHelper"

[tnisan at redhat.com]

Tal Nisan has submitted this change and it was merged.

Change subject: restapi: Fix condition in "IconHelper"
......................................................................


restapi: Fix condition in "IconHelper"

This is needed in order to avoid the following findbugs warning, but it
also looks like a real bug:

  Repeated conditional tests

  The code contains a conditional test is performed twice, one right
  after the other (e.g., x == 0 || x == 0). Perhaps the second
  occurrence is intended to be something else (e.g., x == 0 || y == 0).

  Bug kind and pattern: RpC - RpC_REPEATED_CONDITIONAL_TEST

Change-Id: I329dc96c77cd91c175fea8cb70580605dc062782
Signed-off-by: Juan Hernandez <juan.hernandez at redhat.com>
Bug-Url: https://bugzilla.redhat.com/1265716
---
M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/util/IconHelper.java
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Tal Nisan: Passed CI tests
  Jakub Niedermertl: Verified
  Juan Hernandez: Looks good to me, approved



-- 
To view, visit https://gerrit.ovirt.org/46617
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I329dc96c77cd91c175fea8cb70580605dc062782
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.6
Gerrit-Owner: Jakub Niedermertl <jniederm at redhat.com>
Gerrit-Reviewer: Jakub Niedermertl <jniederm at redhat.com>
Gerrit-Reviewer: Juan Hernandez <juan.hernandez at redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan at redhat.com>