Change in ovirt-engine[master]: restapi: Removed the disk "clone" and "detach_only" elements

juan.hernandez at redhat.com juan.hernandez at redhat.com
Mon Sep 28 13:21:39 UTC 2015


Juan Hernandez has submitted this change and it was merged.

Change subject: restapi: Removed the disk "clone" and "detach_only" elements
......................................................................


restapi: Removed the disk "clone" and "detach_only" elements

These elements aren't really part of the representation of disks, but
parameters of the operations to add and remove virtual machines.

The "disks.clone" element was used to indicate that the disks of a new
virtual machine have to be cloned:

  POST /vms
  <vm>
    ...
    <disks>
      <clone>true</clone>
    </disks>
  <vm>

This has been now removed, and replaced by a new "clone" matrix
parameter:

  POST /vms;clone=true
  <vm>
    ...
  </vm>

The "disks.detach_only" element was used to indicate that when removing
a virtual machine the disks don't have to be removed, but just detached
from the virtual machine:

  DELETE /vms/{vm:id}
  <action>
    <vm>
      <disks>
        <detach_only>true</detach_only>
      </disks>
    </vm>
  </action>

This has been now removed, and replaced by a new "detach_only" matrix
parameter:

    DELETE /vms/{vm:id};detach_only=true

Change-Id: I4b3f4d00377c7dd1a102ec8aa8d87059c11d9cd0
Signed-off-by: Juan Hernandez <juan.hernandez at redhat.com>
---
M backend/manager/modules/restapi/README.md
M backend/manager/modules/restapi/interface/definition/src/main/resources/rsdl_metadata.yaml
M backend/manager/modules/restapi/interface/definition/src/main/schema/api.xsd
M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendVmResource.java
M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendVmsResource.java
M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendVmResourceTest.java
M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendVmsResourceTest.java
7 files changed, 81 insertions(+), 19 deletions(-)

Approvals:
  Juan Hernandez: Verified; Looks good to me, approved; Passed CI tests



-- 
To view, visit https://gerrit.ovirt.org/46734
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I4b3f4d00377c7dd1a102ec8aa8d87059c11d9cd0
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Juan Hernandez <juan.hernandez at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Juan Hernandez <juan.hernandez at redhat.com>
Gerrit-Reviewer: automation at ovirt.org



More information about the Engine-commits mailing list