Change in ovirt-engine[master]: restapi: Rename "storage" and "host_storage" elements

juan.hernandez at redhat.com juan.hernandez at redhat.com
Tue Sep 29 10:26:57 UTC 2015


Juan Hernandez has submitted this change and it was merged.

Change subject: restapi: Rename "storage" and "host_storage" elements
......................................................................


restapi: Rename "storage" and "host_storage" elements

The host storage collection used the "storage" and "host_storage"
elements and the "Storage" and "HostStorage" complex types to report the
storage associated to a host:

  GET /hosts/{host:id}/storage
  <host_storage>
    <storage>
      ...
    </storage>
    <storage>
      ...
    </storage>
    ...
  </host_storage>

This doesn't follow the pattern used in the rest of the API, where the
outer element is a plural name and the inner element is the same name
but in singular. This patch changes the host storage collection to use
"host_storages" as the outer element and "host_storage" as the inner
element:

  GET /hosts/{host:id}/storage
  <host_storages>
    <host_storage>
      ...
    </host_storage>
    <host_storage>
      ...
    </host_storage>
    ...
  </host_storage>

Change-Id: If83d2a3551f6ddeee36009fe9b6b5a406813746d
Signed-off-by: Juan Hernandez <juan.hernandez at redhat.com>
---
M backend/manager/modules/restapi/README.md
M backend/manager/modules/restapi/interface/common/jaxrs/src/test/java/org/ovirt/engine/api/common/util/LinkHelperTest.java
M backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/resource/HostStorageResource.java
M backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/resource/StorageResource.java
M backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/utils/LinkHelper.java
M backend/manager/modules/restapi/interface/definition/src/main/schema/api.xsd
M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendHostStorageResource.java
M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendStorageDomainResource.java
M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendStorageDomainsResource.java
M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendStorageResource.java
M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendHostStorageResourceTest.java
M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendStorageDomainsResourceTest.java
M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendVmDisksResourceTest.java
M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/DiskMapper.java
M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/StorageDomainMapper.java
M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/StorageLogicalUnitMapper.java
M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/StorageVolumeGroupMapper.java
M backend/manager/modules/restapi/types/src/test/java/org/ovirt/engine/api/restapi/types/LunDiskMapperTest.java
M backend/manager/modules/restapi/types/src/test/java/org/ovirt/engine/api/restapi/types/StorageDomainMapperTest.java
M backend/manager/modules/restapi/types/src/test/java/org/ovirt/engine/api/restapi/types/StorageLogicalUnitMapperTest.java
M backend/manager/modules/restapi/types/src/test/java/org/ovirt/engine/api/restapi/types/StorageVolumeGroupMapperTest.java
21 files changed, 125 insertions(+), 84 deletions(-)

Approvals:
  Juan Hernandez: Verified; Looks good to me, approved; Passed CI tests



-- 
To view, visit https://gerrit.ovirt.org/46782
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: If83d2a3551f6ddeee36009fe9b6b5a406813746d
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Juan Hernandez <juan.hernandez at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Juan Hernandez <juan.hernandez at redhat.com>
Gerrit-Reviewer: automation at ovirt.org



More information about the Engine-commits mailing list