Change in ovirt-engine[master]: core: Make "SysprepHandler.timeZoneIndex" private

[juan.hernandez at redhat.com]

Juan Hernandez has submitted this change and it was merged.

Change subject: core: Make "SysprepHandler.timeZoneIndex" private
......................................................................


core: Make "SysprepHandler.timeZoneIndex" private

This is needed in order to avoid the following findbugs warning:

  Field is a mutable collection which should be package protected

  A mutable collection instance is assigned to a final static field,
  thus can be changed by malicious code or by accident from another
  package. The field could be made package protected to avoid this
  vulnerability. Alternatively you may wrap this field into
  Collections.unmodifiableSet/List/Map/etc. to avoid this vulnerability.

  Bug kind and pattern: MS - MS_MUTABLE_COLLECTION_PKGPROTECT

Change-Id: I6fc8e9cf3218312d53acc87eda3b66e373ef9ca0
Signed-off-by: Juan Hernandez <juan.hernandez at redhat.com>
---
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/SysprepHandler.java
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Juan Hernandez: Verified; Looks good to me, approved
  Jenkins CI: Passed CI tests



-- 
To view, visit https://gerrit.ovirt.org/46598
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I6fc8e9cf3218312d53acc87eda3b66e373ef9ca0
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Juan Hernandez <juan.hernandez at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Juan Hernandez <juan.hernandez at redhat.com>
Gerrit-Reviewer: Shahar Havivi <shavivi at redhat.com>
Gerrit-Reviewer: automation at ovirt.org