Change in ovirt-engine[master]: engine: Remove the action version map notion

[amureini at redhat.com]

Allon Mureinik has submitted this change and it was merged.

Change subject: engine: Remove the action version map notion
......................................................................


engine: Remove the action version map notion

The action version map is a (now outdated) mapping between action types
(constants from VdcActionType) and the minimal cluster/DC levels
required to execute them. This mechanism has several inherit drawbacks:

* It's a parallel effort to the FeatureSupported, splitting the same
  logic to two places, making the codebase harder to follow and
  understand.
* It's checked in CommandBase's infrastructure, for every command run,
  adding a performance and complexity penalty to even to (most of the)
  commands that don't need it.
* It returns a generic message, with no option for a specific feature to
  add its custom message.

Versions 3.5 and 3.6, with their abundance of new features did not add a
thing to the action version map, reinforcing the notion that this
feature is being phased out in favor of the more modern FeatureSupported
infrastructure.

In 4.0, as the support for 3.4 (and lower) DC/clusters was removed, this
feature remains a mute point, a check that always succeeds. This patch
finishes the job and removes this feature entirely. The patch removes
the following:

1. The ActionVersionMap business entity
2. The action_version_map database table and all the stored
   procedures and DAO methods referencing it, including their tests
3. The now unused GetCommandsCompatibilityVersionsQuery that exposes
   this information to the frontend and the tooling around it

Change-Id: I97d4345363e1d47c4570f6bbf61a0e07f1052419
Signed-off-by: Allon Mureinik <amureini at redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandBase.java
D backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetCommandsCompatibilityVersionsQuery.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/CommandBaseTest.java
D backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/GetCommandsCompatibilityVersionsQueryTest.java
M backend/manager/modules/common/exclude-filters.xml
D backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/ActionVersionMap.java
D backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/CommandVersionsInfo.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/VdcQueryType.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/ActionGroupDao.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/ActionGroupDaoImpl.java
M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/ActionGroupDaoTest.java
M backend/manager/modules/dal/src/test/resources/fixtures.xml
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/dataprovider/AsyncDataProvider.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmListModel.java
D packaging/dbscripts/action_version_map_sp.sql
A packaging/dbscripts/upgrade/04_00_0410_drop_action_group_map.sql
16 files changed, 2 insertions(+), 455 deletions(-)

Approvals:
  Tal Nisan: Looks good to me, approved
  Eli Mesika: Looks good to me, but someone else must approve
  Daniel Erez: Looks good to me, approved
  Allon Mureinik: Verified; Passed CI tests
  Vojtech Szocs: Looks good to me, but someone else must approve



-- 
To view, visit https://gerrit.ovirt.org/55563
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I97d4345363e1d47c4570f6bbf61a0e07f1052419
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Daniel Erez <derez at redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Oved Ourfali <oourfali at redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan at redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vszocs at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>