Change in ovirt-engine[master]: engine: Block move network by removing the old att and creat...

alkaplan at redhat.com alkaplan at redhat.com
Wed Apr 6 09:01:03 UTC 2016


Alona Kaplan has submitted this change and it was merged.

Change subject: engine: Block move network by removing the old att and creating a new one
......................................................................


engine: Block move network by removing the old att and creating a new one

Moving a network from nic to nic should be done only by changing the
nic_id/nic_name of the already existing attachment that contains the
network.

Removing the old attachmnet and creating a new one for the same
network, shouldn't be supported by the setup networks command.

Change-Id: Ibb28c11eda2dbf702614ba86272ed84b73423a15
Bug-Url: https://bugzilla.redhat.com/1322947
Signed-off-by: Alona Kaplan <alkaplan at redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/host/HostSetupNetworksValidator.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/NetworkAttachmentValidator.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/validator/NetworkAttachmentValidatorTest.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/EngineMessage.java
M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties
M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java
M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
7 files changed, 83 insertions(+), 0 deletions(-)

Approvals:
  Marcin Mirecki: Looks good to me, but someone else must approve
  Alona Kaplan: Verified; Passed CI tests
  Moti Asayag: Looks good to me, approved



-- 
To view, visit https://gerrit.ovirt.org/55687
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ibb28c11eda2dbf702614ba86272ed84b73423a15
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alona Kaplan <alkaplan at redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Marcin Mirecki <mmirecki at redhat.com>
Gerrit-Reviewer: Martin Mucha <mmucha at redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag at redhat.com>
Gerrit-Reviewer: Yevgeny Zaspitsky <yzaspits at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>



More information about the Engine-commits mailing list