Change in ovirt-engine[ovirt-engine-3.6]: core: Added cpu profiles permissions propagation

tnisan at redhat.com tnisan at redhat.com
Thu Apr 7 13:47:28 UTC 2016


Tal Nisan has submitted this change and it was merged.

Change subject: core: Added cpu profiles permissions propagation
......................................................................


core: Added cpu profiles permissions propagation

Cpu Profile permissions will now propagate from parent objects of Cpu
Profile.
For example, If you have CpuProfileOperator permissions on a cluster
that has Cpu Profile 'A' then you will automatically have
CpuProfileOperator on 'A' and all the other Cpu Profiles on that cluster.

The list of objects that Cpu Profile permissions progpagates from is:
System -> Storage Domain -> Cluster -> Cpu Profile.

This also solves the problem that admin user (That has SuperUser
permissions on System) couldn't run any virtual machines because it
needed to have specific permissions for a CpuProfile on it's cluster.

Change-Id: Iaf5c142f8e563377cc262bf36ea5a44060b90d81
Bug-Url: https://bugzilla.redhat.com/1143869
Signed-off-by: Tomer Saban <tsaban at redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/profiles/CpuProfileHelper.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/profiles/GetCpuProfilesByClusterIdQuery.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/profiles/CpuProfileDao.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/profiles/CpuProfileDaoImpl.java
M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/profiles/CpuProfileDaoTest.java
M packaging/dbscripts/cpu_profiles_sp.sql
M packaging/dbscripts/create_views.sql
7 files changed, 69 insertions(+), 32 deletions(-)

Approvals:
  Eli Mesika: Looks good to me, but someone else must approve
  Jenkins CI: Passed CI tests
  Tomer Saban: Verified
  Roy Golan: Looks good to me, approved



-- 
To view, visit https://gerrit.ovirt.org/55663
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Iaf5c142f8e563377cc262bf36ea5a44060b90d81
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.6
Gerrit-Owner: Tomer Saban <tsaban at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Roy Golan <rgolan at redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan at redhat.com>
Gerrit-Reviewer: Tomer Saban <tsaban at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>



More information about the Engine-commits mailing list