Change in ovirt-engine[master]: core: minor refactoring in vm-analyze
ahadas at redhat.com
ahadas at redhat.com
Sun Apr 10 08:05:41 UTC 2016
Arik Hadas has submitted this change and it was merged.
Change subject: core: minor refactoring in vm-analyze
......................................................................
core: minor refactoring in vm-analyze
1. Replace if-else statements with easier to read syntax
in the proceedDisappearedVm.
2. Remove redundant variables in handleVmOnDown
3. Remove the arguments of auditVmOnDownEvent
4. Remove redundant check: if dbVm == null in inMigrationTo
method, then its run_on_vds in the database is definitely
different than the monitored host, no need to check that.
Change-Id: I040a5561e96d07d2fb625852ad51a51a9376cf8a
Signed-off-by: Arik Hadas <ahadas at redhat.com>
---
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/monitoring/VmAnalyzer.java
1 file changed, 22 insertions(+), 18 deletions(-)
Approvals:
Shahar Havivi: Looks good to me, approved
Jenkins CI: Passed CI tests
Arik Hadas: Verified
--
To view, visit https://gerrit.ovirt.org/55733
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I040a5561e96d07d2fb625852ad51a51a9376cf8a
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Arik Hadas <ahadas at redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Shahar Havivi <shavivi at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
More information about the Engine-commits
mailing list