Change in ovirt-engine[master]: core: Don't overwrite local domain's format

amureini at redhat.com amureini at redhat.com
Sun Apr 10 10:03:53 UTC 2016


Allon Mureinik has submitted this change and it was merged.

Change subject: core: Don't overwrite local domain's format
......................................................................


core: Don't overwrite local domain's format

ensureStorageFormatInitialized(), called from
AddStorageDomainCommand#validate() already takes care of calculating the
correct format for the domain. Overwriting in in
AddLocalStorageDomainCommand is at best just redundant (for data
domains) and at worst just plain wrong (for export and iso domains).

Change-Id: Iead537b06ce234f41ccb399d757eff442c5342e4
Bug-Url: https://bugzilla.redhat.com/1323462
Signed-off-by: Allon Mureinik <amureini at redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/domain/AddLocalStorageDomainCommand.java
1 file changed, 0 insertions(+), 3 deletions(-)

Approvals:
  Tal Nisan: Looks good to me, approved
  Jenkins CI: Passed CI tests
  Allon Mureinik: Verified



-- 
To view, visit https://gerrit.ovirt.org/55836
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Iead537b06ce234f41ccb399d757eff442c5342e4
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Liron Aravot <laravot at redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>



More information about the Engine-commits mailing list