Change in ovirt-engine[ovirt-engine-3.6]: userportal: use the default host that was set in vm in template

tnisan at redhat.com tnisan at redhat.com
Tue Apr 19 13:00:05 UTC 2016


Tal Nisan has submitted this change and it was merged.

Change subject: userportal: use the default host that was set in vm in template
......................................................................


userportal: use the default host that was set in vm in template

When creating a template from a vm that has a default host specified the
host was not passed to the created template.

The fix was in two layers:
1. UI - UserPortalListModel - populate the default host in the newly created template.
2. Backend - AddVmTemplateCommand - changed the permission check so that the user will
be able to create a template from a vm with default host.

Added tests.

Change-Id: I65c7735e59b2056c341b35eaa9d6b840dc6608d7
Bug-Url: https://bugzilla.redhat.com/1284472
Signed-off-by: Jenny Tokar <jtokar at redhat.com>
(cherry picked from commit d2f5165)
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmTemplateCommand.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/AddVmTemplateCommandTest.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/userportal/UserPortalListModel.java
3 files changed, 53 insertions(+), 3 deletions(-)

Approvals:
  Tal Nisan: Looks good to me, but someone else must approve
  Jenkins CI: Passed CI tests
  Roy Golan: Looks good to me, approved
  Jenny Tokar: Verified



-- 
To view, visit https://gerrit.ovirt.org/56250
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I65c7735e59b2056c341b35eaa9d6b840dc6608d7
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.6
Gerrit-Owner: Jenny Tokar <jtokar at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Jenny Tokar <jtokar at redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan at redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>



More information about the Engine-commits mailing list