Change in ovirt-engine[master]: engine: use IpAddressPredicate in IP address comparisons

alkaplan at redhat.com alkaplan at redhat.com
Wed Apr 20 08:36:34 UTC 2016


Alona Kaplan has submitted this change and it was merged.

Change subject: engine: use IpAddressPredicate in IP address comparisons
......................................................................


engine: use IpAddressPredicate in IP address comparisons

Use IpAddressPredicate in different IP address comparisons
instead of the simple string comparisons.

Change-Id: Ib77da9b7cde92649b9accbb9dabffcc781bf9c72
Bug-Url: https://bugzilla.redhat.com/1080725
Signed-off-by: Yevgeny Zaspitsky <yzaspits at redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/NetworkAttachmentValidator.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/validator/NetworkAttachmentValidatorTest.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsBrokerObjectsBuilder.java
3 files changed, 124 insertions(+), 57 deletions(-)

Approvals:
  Alona Kaplan: Looks good to me, approved; Passed CI tests
  Yevgeny Zaspitsky: Verified



-- 
To view, visit https://gerrit.ovirt.org/56092
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ib77da9b7cde92649b9accbb9dabffcc781bf9c72
Gerrit-PatchSet: 7
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Yevgeny Zaspitsky <yzaspits at redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Yevgeny Zaspitsky <yzaspits at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>



More information about the Engine-commits mailing list