Change in ovirt-engine[master]: core: cleanup vm-manager

[ahadas at redhat.com]

Arik Hadas has submitted this change and it was merged.

Change subject: core: cleanup vm-manager
......................................................................


core: cleanup vm-manager

1. Reduce the constructor visibility to package-protected

2. Use injection to get the required DAOs

3. Rename the 'id' field to vmId

4. Move the instantiation of 'lock' field to the constructor

Change-Id: I435344a4f80de3bd826f8e5e062c1d13b14c15e5
Signed-off-by: Arik Hadas <ahadas at redhat.com>
---
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/ResourceManager.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VmManager.java
2 files changed, 20 insertions(+), 26 deletions(-)

Approvals:
  Shahar Havivi: Looks good to me, approved
  Jenkins CI: Passed CI tests
  Shmuel Leib Melamud: Looks good to me, but someone else must approve
  Arik Hadas: Verified



-- 
To view, visit https://gerrit.ovirt.org/56357
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I435344a4f80de3bd826f8e5e062c1d13b14c15e5
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Arik Hadas <ahadas at redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Michal Skrivanek <mskrivan at redhat.com>
Gerrit-Reviewer: Shahar Havivi <shavivi at redhat.com>
Gerrit-Reviewer: Shmuel Leib Melamud <smelamud at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>