Change in ovirt-engine[master]: engine: Engine may kill session that is still in use

[mperina at redhat.com]

Martin Peřina has submitted this change and it was merged.

Change subject: engine: Engine may kill session that is still in use
......................................................................


engine: Engine may kill session that is still in use

Engine may kill session for restapi async task
before the command gets a change to execute.

Add session_id to command_entities table so
commands can be tracked by engine session id.
Only session that don't have an active command
can be purged.

Change-Id: Id538895f73dcc39c6940fc17dca6b602da075805
Bug-Url: https://bugzilla.redhat.com/1148514
Signed-off-by: Ravi Nori <rnori at redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandBase.java
A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RunAsyncActionCommand.java
A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/aaa/SSOSessionUtils.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/aaa/SessionDataContainer.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/tasks/CommandCoordinatorImpl.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/tasks/CommandCoordinatorUtil.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/tasks/CommandsRepository.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/tasks/interfaces/CommandCRUDOperations.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/AbstractGetEntitiesWithPermittedActionParametersQueryTest.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/BaseCommandTest.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/aaa/SessionDataContainerTest.java
A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/RunAsyncActionParameters.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/VdcActionType.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/CommandEntity.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/CommandEntityDaoImpl.java
M backend/manager/modules/dal/src/test/resources/fixtures.xml
M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendResource.java
M packaging/dbscripts/command_entities_sp.sql
A packaging/dbscripts/upgrade/04_00_0530_add_engine_session_seq_id_to_command_entities.sql
19 files changed, 235 insertions(+), 21 deletions(-)

Approvals:
  Martin Peřina: Verified; Looks good to me, approved
  Jenkins CI: Passed CI tests



-- 
To view, visit https://gerrit.ovirt.org/55409
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Id538895f73dcc39c6940fc17dca6b602da075805
Gerrit-PatchSet: 15
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Ravi Nori <rnori at redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Juan Hernandez <juan.hernandez at redhat.com>
Gerrit-Reviewer: Martin Peřina <mperina at redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag at redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali at redhat.com>
Gerrit-Reviewer: Ravi Nori <rnori at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>