Change in ovirt-engine[master]: engine: Refactor RemoveCinderDiskVolumeCommand CB

mlipchuk at redhat.com mlipchuk at redhat.com
Sun Apr 24 08:04:55 UTC 2016


Maor Lipchuk has submitted this change and it was merged.

Change subject: engine: Refactor RemoveCinderDiskVolumeCommand CB
......................................................................


engine: Refactor RemoveCinderDiskVolumeCommand CB

Refactor RemoveCinderDiskVolumeCommand to inherit from
ConcurrentChildCommandsExecutionCallback to minimize code duplication
and ease future refactors.

Change-Id: Ia060a9b3bf50a330c1d0e3c06936ec52300fea57
Signed-off-by: Fred Rolland <frolland at redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/cinder/RemoveCinderDiskVolumeCommandCallback.java
1 file changed, 22 insertions(+), 43 deletions(-)

Approvals:
  Freddy Rolland: Verified
  Maor Lipchuk: Looks good to me, approved; Passed CI tests



-- 
To view, visit https://gerrit.ovirt.org/54161
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ia060a9b3bf50a330c1d0e3c06936ec52300fea57
Gerrit-PatchSet: 15
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Freddy Rolland <frolland at redhat.com>
Gerrit-Reviewer: Daniel Erez <derez at redhat.com>
Gerrit-Reviewer: Fred Rolland <frolland at redhat.com>
Gerrit-Reviewer: Freddy Rolland <frolland at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Liron Aravot <laravot at redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipchuk at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>



More information about the Engine-commits mailing list