Change in ovirt-engine[master]: core: Reuse ImportValidator in ImportVmTemplate

amureini at redhat.com amureini at redhat.com
Tue Apr 26 07:01:32 UTC 2016


Allon Mureinik has submitted this change and it was merged.

Change subject: core: Reuse ImportValidator in ImportVmTemplate
......................................................................


core: Reuse ImportValidator in ImportVmTemplate

[Re]use ImportValidator instead of copy pasting the same code between it
and ImportVmTemplateCommand

There a VERY slight performance benefit here too, as it saves the
compilation of the same regex in two places instead of just one.

Change-Id: I2e351dca07e21211dda36c83f7b4bbd03c168868
Signed-off-by: Allon Mureinik <amureini at redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/exportimport/ImportVmTemplateCommand.java
1 file changed, 2 insertions(+), 45 deletions(-)

Approvals:
  Tal Nisan: Looks good to me, approved
  Allon Mureinik: Verified; Passed CI tests
  Arik Hadas: Looks good to me, but someone else must approve



-- 
To view, visit https://gerrit.ovirt.org/56487
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I2e351dca07e21211dda36c83f7b4bbd03c168868
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan at redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Tal Nisan <tnisan at redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek at redhat.com>
Gerrit-Reviewer: Yevgeny Zaspitsky <yzaspits at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>



More information about the Engine-commits mailing list