Change in ovirt-engine[ovirt-engine-4.0]: core: add logicalName to DiskAttachment

tnisan at redhat.com tnisan at redhat.com
Wed Aug 3 13:29:25 UTC 2016


Tal Nisan has submitted this change and it was merged.

Change subject: core: add logicalName to DiskAttachment
......................................................................


core: add logicalName to DiskAttachment

In v3 of the the REST API, the logical name of a disk could be retrieved
from ovirt-engine/api/v3/vms/<vm_id>/disks.

Since in v4 DiskAttachmentsService replaces DisksService, the field
logicalName should be added to DiskAttachment so that it can be
retrieved from /ovirt-engine/api/vms/<vm_id>/diskattachments and
/ovirt-engine/api/vms/<vm_id>/diskattachments/<disk_attachment_id>.

Change-Id: I102e2e79dcf39aef22bdd36dd12d323564458930
Bug-Url: https://bugzilla.redhat.com/1358271
Signed-off-by: Idan Shaby <ishaby at redhat.com>
---
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/storage/DiskVmElement.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/DiskVmElementDaoImpl.java
M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/v3/adapters/V3DiskOutAdapter.java
M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/DiskAttachmentMapper.java
M packaging/dbscripts/create_views.sql
5 files changed, 20 insertions(+), 6 deletions(-)

Approvals:
  Tal Nisan: Looks good to me, approved
  Jenkins CI: Passed CI tests
  Idan Shaby: Verified



-- 
To view, visit https://gerrit.ovirt.org/61894
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I102e2e79dcf39aef22bdd36dd12d323564458930
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-4.0
Gerrit-Owner: Idan Shaby <ishaby at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Idan Shaby <ishaby at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Juan Hernandez <juan.hernandez at redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>



More information about the Engine-commits mailing list