Change in ovirt-engine[master]: webadmin: Don't call finazlize on image upload progress.
derez at redhat.com
derez at redhat.com
Tue Aug 9 08:32:25 UTC 2016
Daniel Erez has submitted this change and it was merged.
Change subject: webadmin: Don't call finazlize on image upload progress.
......................................................................
webadmin: Don't call finazlize on image upload progress.
Currently, when a progress callback triggered while uploading an image,
and the upload status is not "TRANSFERRING", there is a call to finalize
upload. This is wrong, because in any scenario in which the status
becomes anything other than "TRANSFERRING", finalizing the upload
already happens. that means that currently a call for finalizing will
happen twice.
Remove the call for finalizeUpload in onProgress().
Change-Id: Iad2ad4b7500d44be2ff2ca9ea7ed91bc61c5c313
Signed-off-by: Amit Aviram <aaviram at redhat.com>
---
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/UploadImageModel.java
1 file changed, 0 insertions(+), 1 deletion(-)
Approvals:
Daniel Erez: Looks good to me, approved
Jenkins CI: Passed CI tests
Amit Aviram: Verified
--
To view, visit https://gerrit.ovirt.org/62017
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Iad2ad4b7500d44be2ff2ca9ea7ed91bc61c5c313
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Amit Aviram <aaviram at redhat.com>
Gerrit-Reviewer: Amit Aviram <aaviram at redhat.com>
Gerrit-Reviewer: Daniel Erez <derez at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
More information about the Engine-commits
mailing list