Change in ovirt-engine[ovirt-engine-4.0]: webadmin: image upload - image info detection

[tnisan at redhat.com]

Tal Nisan has submitted this change and it was merged.

Change subject: webadmin: image upload - image info detection
......................................................................


webadmin: image upload - image info detection

On 'Image Upload' dialog, upon selection a file:
Image information is detected by its header and according
to qcow2 spec [1].

The following properties are detected (and displayed in dialog):
* Volume format (raw/cow).
* Actual size.
(For COW:)
* Virtual size.
* Backing file.
* Qcow2 Compat (0.10/1.1).

Validation:
* Format is set according to the detected info.
* Uploading an image with a backing file is unsupported.
* Only compat 0.10 is currently supported.
* Minimal disk size should be max(actual, virtual).

[1] See http://git.qemu.org/?p=qemu.git;a=blob;f=docs/specs/qcow2.txt

Screenshot: http://imgur.com/a/Z1zWC

Change-Id: I726678a14451a7faff3a18afa25d013b7f5aa7d5
Bug-Url: https://bugzilla.redhat.com/1357548
Signed-off-by: Daniel Erez <derez at redhat.com>
---
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/CommonApplicationConstants.java
A frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/storage/ImageInfoForm.java
M frontend/webadmin/modules/gwt-common/src/main/resources/org/ovirt/engine/ui/common/CommonApplicationConstants.properties
A frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/ImageInfoModel.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/UploadImageModel.java
M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/Enums.java
M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/UIConstants.java
M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/UIMessages.java
M frontend/webadmin/modules/uicompat/src/main/resources/org/ovirt/engine/ui/uicompat/Enums.properties
M frontend/webadmin/modules/uicompat/src/main/resources/org/ovirt/engine/ui/uicompat/UIConstants.properties
M frontend/webadmin/modules/uicompat/src/main/resources/org/ovirt/engine/ui/uicompat/UIMessages.properties
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/ApplicationConstants.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/storage/UploadImagePopupView.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/storage/UploadImagePopupView.ui.xml
M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/webadmin/ApplicationConstants.properties
15 files changed, 343 insertions(+), 60 deletions(-)

Approvals:
  Tal Nisan: Looks good to me, approved
  Daniel Erez: Verified
  Jenkins CI: Passed CI tests



-- 
To view, visit https://gerrit.ovirt.org/62426
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I726678a14451a7faff3a18afa25d013b7f5aa7d5
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-4.0
Gerrit-Owner: Daniel Erez <derez at redhat.com>
Gerrit-Reviewer: Amit Aviram <aaviram at redhat.com>
Gerrit-Reviewer: Daniel Erez <derez at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Tal Nisan <tnisan at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>