Change in ovirt-engine-sdk[master]: Name element tag by the enitity, which is written

omachace at redhat.com omachace at redhat.com
Thu Aug 18 14:38:07 UTC 2016


Ondra Machacek has submitted this change and it was merged.

Change subject: Name element tag by the enitity, which is written
......................................................................


Name element tag by the enitity, which is written

When writing XML, we always written XML element same as member,
which we wanted to write. This patch changes it, so we name the
singular element tag same as entity we write, not the member.

For example if we want to create bonds, we will send following xml:

  <action>
    <modified_bonds>
      <host_nic>
        <bonding>
          <options>...</options>
          <slaves>
            <host_nic>
              <name>eth0</name>
            </host_nic>
            <host_nic>
              <name>eth1</name>
            </host_nic>
          </slaves>
        </bonding>
        <name>bond0</name>
      </host_nic>
    </modified_bonds>
  </action>

Previously we sent <slave> instead of <host_nic> in <slaves>
element.

Change-Id: I277bc4678ab8d6da3d640a3863c6341b6e7a62ea
Signed-off-by: Ondra Machacek <omachace at redhat.com>
---
M generator/src/main/java/org/ovirt/sdk/python/WritersGenerator.java
M sdk/tests/test_setupnetworks.py
2 files changed, 6 insertions(+), 5 deletions(-)

Approvals:
  Ondra Machacek: Verified; Looks good to me, approved
  Juan Hernandez: Looks good to me, but someone else must approve
  Jenkins CI: Passed CI tests



-- 
To view, visit https://gerrit.ovirt.org/62554
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I277bc4678ab8d6da3d640a3863c6341b6e7a62ea
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine-sdk
Gerrit-Branch: master
Gerrit-Owner: Ondra Machacek <omachace at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Juan Hernandez <juan.hernandez at redhat.com>
Gerrit-Reviewer: Ondra Machacek <omachace at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>



More information about the Engine-commits mailing list