Change in ovirt-engine[ovirt-engine-4.0]: core: fix possible deadlock on update cluster version

[tnisan at redhat.com]

Tal Nisan has submitted this change and it was merged.

Change subject: core: fix possible deadlock on update cluster version
......................................................................


core: fix possible deadlock on update cluster version

Sort the VMs that are being updated according to the order that
the monitoring updates VM related data to prevent a possible
race when both are done within a transaction (with postgres
lower or equal to 9.2 where updates of entries with foreign
key locks the row of the foreign entity in the transaction
scope).

Change-Id: Iedceef969c8823200bbdb27a332831e9305aebcf
Bug-Url: https://bugzilla.redhat.com/1366786
Signed-off-by: Arik Hadas <ahadas at redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ClusterOperationCommandBase.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateClusterCommand.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/UpdateClusterCommandTest.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/monitoring/VmsMonitoring.java
4 files changed, 33 insertions(+), 17 deletions(-)

Approvals:
  Shahar Havivi: Looks good to me, approved
  Jenkins CI: Passed CI tests
  Arik Hadas: Verified



-- 
To view, visit https://gerrit.ovirt.org/62518
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Iedceef969c8823200bbdb27a332831e9305aebcf
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-4.0
Gerrit-Owner: Arik Hadas <ahadas at redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Shahar Havivi <shavivi at redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>