Change in ovirt-engine-sdk[master]: Make sure that query parameters are always sorted

omachace at redhat.com omachace at redhat.com
Mon Aug 29 17:23:14 UTC 2016


Ondra Machacek has submitted this change and it was merged.

Change subject: Make sure that query parameters are always sorted
......................................................................


Make sure that query parameters are always sorted

Currently when we format query parameters we depend on the internal sorting of
the Python 'dict' type. This isn't convenient, specially for tets, as it isn't
possible to predict what will be the query string generated. To avoid that this
patch changes the SDK so that it sorts the query parameters by name before
creating the query string.

Change-Id: I19028dad41872633a82d8cfece9625e782b9d222
Signed-off-by: Juan Hernandez <juan.hernandez at redhat.com>
---
M sdk/lib/ovirtsdk4/__init__.py
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Ondra Machacek: Looks good to me, approved
  Juan Hernandez: Verified
  Jenkins CI: Passed CI tests



-- 
To view, visit https://gerrit.ovirt.org/62926
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I19028dad41872633a82d8cfece9625e782b9d222
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine-sdk
Gerrit-Branch: master
Gerrit-Owner: Juan Hernandez <juan.hernandez at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Juan Hernandez <juan.hernandez at redhat.com>
Gerrit-Reviewer: Ondra Machacek <omachace at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>



More information about the Engine-commits mailing list