Change in ovirt-engine[ovirt-engine-4.0]: restapi: Ignore failures fetching additional disk data

tnisan at redhat.com tnisan at redhat.com
Wed Aug 31 16:29:00 UTC 2016


Tal Nisan has submitted this change and it was merged.

Change subject: restapi: Ignore failures fetching additional disk data
......................................................................


restapi: Ignore failures fetching additional disk data

When disks are retrieved using version 3 of the API additional data is
required, like the disk attachments. If the user doesn't have permission for
the additional data then the complete operation fails. This is a problem for
users that may not have permission for that additional data. In order to avoid
that this patch changes the API so that failures to retrieve the additional
data are just ignored.

Change-Id: I37159aaa3d767df6c83e666bfcd70ad4ff503e87
Bug-Url: https://bugzilla.redhat.com/1368552
Signed-off-by: Juan Hernandez <juan.hernandez at redhat.com>
(cherry picked from commit d4c500b16549b74839220c8a44b35de4ba9da6ee)
---
M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/v3/adapters/V3DiskOutAdapter.java
M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/v3/adapters/V3VmOutAdapter.java
M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/v3/servers/V3VmDisksServer.java
3 files changed, 60 insertions(+), 15 deletions(-)

Approvals:
  Juan Hernandez: Verified; Looks good to me, approved
  Jenkins CI: Passed CI tests



-- 
To view, visit https://gerrit.ovirt.org/63076
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I37159aaa3d767df6c83e666bfcd70ad4ff503e87
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-4.0
Gerrit-Owner: Juan Hernandez <juan.hernandez at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Juan Hernandez <juan.hernandez at redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>



More information about the Engine-commits mailing list