Change in ovirt-engine[master]: restapi: Reflecting template RNG settings to new VM
Code Review
gerrit at ovirt.org
Thu Dec 1 14:50:30 UTC 2016
>From Tomas Jelinek <tjelinek at redhat.com>:
Tomas Jelinek has submitted this change and it was merged.
Change subject: restapi: Reflecting template RNG settings to new VM
......................................................................
restapi: Reflecting template RNG settings to new VM
Non-cluster vm-like entities (Blank template and instance types) use
`urandom` rng source to encode both `urandom` and `random` depending on
effective compatibility version.
This version ensures that when new VM is created based on Blank template
or instance type, rng source will be correctly interpreted.
Change-Id: Id9a65fb4aa3d6aee126ba72beb0bca488ed56d33
Bug-Url: https://bugzilla.redhat.com/1374227
Signed-off-by: Jakub Niedermertl <jniederm at redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmAndCloneImageCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmTemplateCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RunVmCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/utils/VmDeviceUtils.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/VirtIoRngValidator.java
M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendVmsResource.java
A backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/RngUtils.java
8 files changed, 116 insertions(+), 59 deletions(-)
Approvals:
Tomas Jelinek: Looks good to me, approved
Jakub Niedermertl: Verified
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/67050
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Id9a65fb4aa3d6aee126ba72beb0bca488ed56d33
Gerrit-PatchSet: 9
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Jakub Niedermertl <jniederm at redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas at redhat.com>
Gerrit-Reviewer: Jakub Niedermertl <jniederm at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Juan Hernandez <juan.hernandez at redhat.com>
Gerrit-Reviewer: Shahar Havivi <shavivi at redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
More information about the Engine-commits
mailing list