Change in ovirt-engine[ovirt-engine-4.0]: webadmin: Fix custom bond mode option input

Code Review gerrit at ovirt.org
Tue Dec 6 12:32:17 UTC 2016


>From Tal Nisan <tnisan at redhat.com>:

Tal Nisan has submitted this change and it was merged.

Change subject: webadmin: Fix custom bond mode option input
......................................................................


webadmin: Fix custom bond mode option input

The label and the input for "Custom Mode" options in the
SetupNetworksBondPopupView was only visible, if the bonding
mode is chosen to 'Custom'. In the previous implementation the higher
level container in the user interface did not provide enough space to
receive user inputs for "Custom Mode" options. Without choosing the
"Custom Mode", the user was not aware of the input of "Custom Mode"
options.

The higher level container in the user interface is increased and
they layout is changed to a Container of bootstrap grid system.
Additionally the "Custom Mode" options input is disabled, if the user
does not choose the "Custom Mode".

Change-Id: I4b7a4d251cdb50d5fa32fccb50910c9decc730d9
Bug-Url: https://bugzilla.redhat.com/1391130
Signed-off-by: Dominik Holler <dholler at redhat.com>
(cherry picked from commit 7a38c09d9a0f1691327f6620b2e198e0cd7dd651)
---
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/SetupNetworksBondPopupView.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/SetupNetworksBondPopupView.ui.xml
2 files changed, 16 insertions(+), 16 deletions(-)

Approvals:
  Dominik Holler: Verified
  Jenkins CI: Passed CI tests
  Greg Sheremeta: Looks good to me, approved
  Vojtech Szocs: Looks good to me, approved



-- 
To view, visit https://gerrit.ovirt.org/67809
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I4b7a4d251cdb50d5fa32fccb50910c9decc730d9
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-4.0
Gerrit-Owner: Dominik Holler <dholler at redhat.com>
Gerrit-Reviewer: Dominik Holler <dholler at redhat.com>
Gerrit-Reviewer: Greg Sheremeta <gshereme at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Tal Nisan <tnisan at redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vszocs at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>



More information about the Engine-commits mailing list