Change in ovirt-engine[master]: core: method returning Optional<?> must not return null

Code Review gerrit at ovirt.org
Wed Dec 7 15:16:27 UTC 2016


>From Martin Sivák <msivak at redhat.com>:

Martin Sivák has submitted this change and it was merged.

Change subject: core: method returning Optional<?> must not return null
......................................................................


core: method returning Optional<?> must not return null

… otherwise it defies idea behind optional and introduces threat of
NPE.

Change-Id: Iebdd75e4e4e65ccf5482e0d0cb65aca7d492a03c
Signed-off-by: Martin Mucha <mmucha at redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/SchedulingManager.java
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Martin Sivák: Looks good to me, approved
  Martin Mucha: Verified
  Jenkins CI: Passed CI tests



-- 
To view, visit https://gerrit.ovirt.org/67737
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Iebdd75e4e4e65ccf5482e0d0cb65aca7d492a03c
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Martin Mucha <mmucha at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Marcin Mirecki <mmirecki at redhat.com>
Gerrit-Reviewer: Martin Mucha <mmucha at redhat.com>
Gerrit-Reviewer: Martin Sivák <msivak at redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>



More information about the Engine-commits mailing list