Change in ovirt-engine[master]: core: AddDiskCommandTest create image methods

[Code Review]

>From Tal Nisan <tnisan at redhat.com>:

Tal Nisan has submitted this change and it was merged.

Change subject: core: AddDiskCommandTest create image methods
......................................................................


core: AddDiskCommandTest create image methods

Most of the image creating methods did nothing more than call a single
setter, offering no benefit over just calling this setter.

The overloaded method that received a size even added confusion as in
most cases this size was completely arbitrary, and had no effect on the
test.

This patch cleans up the test by removing these useless methods and
calling DiskImage's setters directly.

Change-Id: I7cb3a7cb4a0202d17622698ce2d8c206b570470a
Signed-off-by: Allon Mureinik <amureini at redhat.com>
---
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/disk/AddDiskCommandTest.java
1 file changed, 19 insertions(+), 39 deletions(-)

Approvals:
  Tal Nisan: Looks good to me, approved
  Jenkins CI: Passed CI tests
  Allon Mureinik: Verified
  Freddy Rolland: Looks good to me, but someone else must approve



-- 
To view, visit https://gerrit.ovirt.org/67922
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I7cb3a7cb4a0202d17622698ce2d8c206b570470a
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Freddy Rolland <frolland at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Tal Nisan <tnisan at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>