Change in ovirt-engine[master]: core: AddDiskCommandTest storage domain size mocking

[Code Review]

>From Tal Nisan <tnisan at redhat.com>:

Tal Nisan has submitted this change and it was merged.

Change subject: core: AddDiskCommandTest storage domain size mocking
......................................................................


core: AddDiskCommandTest storage domain size mocking

The AddDiskCommand does not handle the free space validations directly
(it uses a StorageDomainValidator instance instead). Thus, its test
should not care about free and used space in the mocked StorageDomain
object.

This patch removes these mockings and makes the test clearer and easier
to understand and navigate.

Change-Id: I901e3a342e252121c085d7834aed0b708fb4bace
Signed-off-by: Allon Mureinik <amureini at redhat.com>
---
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/disk/AddDiskCommandTest.java
1 file changed, 1 insertion(+), 9 deletions(-)

Approvals:
  Tal Nisan: Looks good to me, approved
  Jenkins CI: Passed CI tests
  Allon Mureinik: Verified
  Freddy Rolland: Looks good to me, but someone else must approve



-- 
To view, visit https://gerrit.ovirt.org/67921
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I901e3a342e252121c085d7834aed0b708fb4bace
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Freddy Rolland <frolland at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Tal Nisan <tnisan at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>