Change in ovirt-engine[master]: core: AddDiskCommandTest: Remove MAX_DISK_SIZE constant

Code Review gerrit at ovirt.org
Thu Dec 8 09:28:18 UTC 2016


>From Tal Nisan <tnisan at redhat.com>:

Tal Nisan has submitted this change and it was merged.

Change subject: core: AddDiskCommandTest: Remove MAX_DISK_SIZE constant
......................................................................


core: AddDiskCommandTest: Remove MAX_DISK_SIZE constant

This constant should mimic the value of the
MaxDiskBlockSize config value.
This patch cleans up the mocking and uses it explicitly to make the test
more straight forward.

Change-Id: I53624b0ddfffd737370fc62ea969ca03f43a82bf
Signed-off-by: Allon Mureinik <amureini at redhat.com>
---
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/disk/AddDiskCommandTest.java
1 file changed, 4 insertions(+), 7 deletions(-)

Approvals:
  Tal Nisan: Looks good to me, approved
  Jenkins CI: Passed CI tests
  Allon Mureinik: Verified
  Freddy Rolland: Looks good to me, but someone else must approve



-- 
To view, visit https://gerrit.ovirt.org/67919
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I53624b0ddfffd737370fc62ea969ca03f43a82bf
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Freddy Rolland <frolland at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Tal Nisan <tnisan at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>



More information about the Engine-commits mailing list