Change in ovirt-engine[master]: core: Fix CloneVmCommand when the VM is based on template
Code Review
gerrit at ovirt.org
Thu Dec 8 09:39:57 UTC 2016
>From Tal Nisan <tnisan at redhat.com>:
Tal Nisan has submitted this change and it was merged.
Change subject: core: Fix CloneVmCommand when the VM is based on template
......................................................................
core: Fix CloneVmCommand when the VM is based on template
In case of a VM based on template the decision whether the command is using
a callback or not is determined in the superclass AddVmCommand wrongly,
the decision was moved to CloneVmCommand itself and is determined
according to whether the VM has disks or not
Change-Id: I22ed9e67923a3379c9bf061546249f3966af7b52
Bug-Url: https://bugzilla.redhat.com/1395793
Signed-off-by: Tal Nisan <tnisan at redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CloneVmCommand.java
1 file changed, 1 insertion(+), 0 deletions(-)
Approvals:
Tal Nisan: Verified
Jenkins CI: Passed CI tests
Liron Aravot: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/67892
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I22ed9e67923a3379c9bf061546249f3966af7b52
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Tal Nisan <tnisan at redhat.com>
Gerrit-Reviewer: Ala Hino <ahino at redhat.com>
Gerrit-Reviewer: Amit Aviram <aaviram at redhat.com>
Gerrit-Reviewer: Freddy Rolland <frolland at redhat.com>
Gerrit-Reviewer: Idan Shaby <ishaby at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Liron Aravot <laravot at redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
More information about the Engine-commits
mailing list