Change in ovirt-engine[master]: core: removed duplicity + potential NPE

Code Review gerrit at ovirt.org
Tue Dec 13 11:59:44 UTC 2016


>From Moti Asayag <masayag at redhat.com>:

Moti Asayag has submitted this change and it was merged.

Change subject: core: removed duplicity + potential NPE
......................................................................


core: removed duplicity + potential NPE

IIUC vmDevice.getHostDevice() shouldn't be null, because if it is, it
will throw NPE latter in process. If that's true, we can remove this
duplicity and simplify code.

Change-Id: Iea7fc8d86173b94702df1a7b1781670dc01c6a76
Signed-off-by: Martin Mucha <mmucha at redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/vm/ActivateDeactivateVmNicCommand.java
1 file changed, 1 insertion(+), 5 deletions(-)

Approvals:
  Marcin Mirecki: Looks good to me, but someone else must approve
  Martin Mucha: Verified
  Jenkins CI: Passed CI tests
  Moti Asayag: Looks good to me, approved



-- 
To view, visit https://gerrit.ovirt.org/67312
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Iea7fc8d86173b94702df1a7b1781670dc01c6a76
Gerrit-PatchSet: 8
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Martin Mucha <mmucha at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Marcin Mirecki <mmirecki at redhat.com>
Gerrit-Reviewer: Martin Mucha <mmucha at redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>



More information about the Engine-commits mailing list