Change in ovirt-engine[master]: core: refactoring fixes
Code Review
gerrit at ovirt.org
Tue Dec 13 12:27:45 UTC 2016
>From Moti Asayag <masayag at redhat.com>:
Moti Asayag has submitted this change and it was merged.
Change subject: core: refactoring fixes
......................................................................
core: refactoring fixes
• used @Inject
• moved vfScheduler.getVnicToVfMap into markVfsAsUsedByVm where it
belongs
• removed inconsistency between getName and getDeviceName
Change-Id: I81ce3f24badfdd60021d04b6db8944137c416005
Signed-off-by: Martin Mucha <mmucha at redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/host/VfSchedulerImpl.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/vm/AbstractVmInterfaceCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/vm/AddVmInterfaceCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/vm/UpdateVmInterfaceCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/SchedulingManager.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/PlugAction.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/HotUnplugNicVDSCommand.java
7 files changed, 36 insertions(+), 31 deletions(-)
Approvals:
Marcin Mirecki: Looks good to me, but someone else must approve
Martin Mucha: Verified
Jenkins CI: Passed CI tests
Moti Asayag: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/67314
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I81ce3f24badfdd60021d04b6db8944137c416005
Gerrit-PatchSet: 10
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Martin Mucha <mmucha at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Marcin Mirecki <mmirecki at redhat.com>
Gerrit-Reviewer: Martin Mucha <mmucha at redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
More information about the Engine-commits
mailing list