Change in ovirt-engine[master]: core: introducing ReduceSANStorageDomainDevicesCommand

Code Review gerrit at ovirt.org
Tue Dec 13 16:08:45 UTC 2016


>From Liron Aravot <laravot at redhat.com>:

Liron Aravot has submitted this change and it was merged.

Change subject: core: introducing ReduceSANStorageDomainDevicesCommand
......................................................................


core: introducing ReduceSANStorageDomainDevicesCommand

This patch adds the EditSANStorageDomainDevicesCommand that'll be used
to edit devices of a block storage domain. The command currently supports
removing devices from domains and may be extended in the future to
support domain extension as well.

The command recieves as a parameter the  list of devices to remove from the
domain, the command will remove the devices one by one - making sure the data
from each device is moved to devices that aren't in the removal list.

Change-Id: I44e905833ecac7a6eba20bb418db82a3a622c4e4
Bug-Url: http://bugzilla.redhat.com/1403839
Signed-off-by: Liron Aravot <laravot at redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/domain/BlockStorageDomainHelper.java
A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/domain/ReduceSANStorageDomainDevicesCommand.java
A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/storage/BlockStorageDomainValidator.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/AuditLogType.java
A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/ReduceSANStorageDomainDevicesCommandParameters.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/VdcActionType.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/EngineMessage.java
M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties
M backend/manager/modules/dal/src/main/resources/bundles/AuditLogMessages.properties
M backend/manager/modules/dal/src/main/resources/bundles/ExecutionMessages.properties
M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java
M frontend/webadmin/modules/frontend/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
14 files changed, 459 insertions(+), 1 deletion(-)

Approvals:
  Liron Aravot: Verified; Looks good to me, approved; Passed CI tests



-- 
To view, visit https://gerrit.ovirt.org/67897
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I44e905833ecac7a6eba20bb418db82a3a622c4e4
Gerrit-PatchSet: 17
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Liron Aravot <laravot at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Liron Aravot <laravot at redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>



More information about the Engine-commits mailing list