Change in ovirt-engine[master]: core: remove redundant validation in create-vm

Code Review gerrit at ovirt.org
Wed Dec 14 21:04:05 UTC 2016


>From Arik Hadas <ahadas at redhat.com>:

Arik Hadas has submitted this change and it was merged.

Change subject: core: remove redundant validation in create-vm
......................................................................


core: remove redundant validation in create-vm

We usually do not validate things in vds commands since they are
supposed to be validated in the bll commands. We have some
legacy checks in CreateVm though. This patch removes one of them
since we need the ability to run VMs in UNKNOWN status (these
that are configured with a VM lease only).

Change-Id: I0cbfe7ae1a2b144577c37a77656a5b4a251075a6
Signed-off-by: Arik Hadas <ahadas at redhat.com>
---
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/CreateVmVDSCommand.java
1 file changed, 0 insertions(+), 6 deletions(-)

Approvals:
  Shahar Havivi: Looks good to me, approved
  Shmuel Leib Melamud: Looks good to me, but someone else must approve
  Arik Hadas: Verified; Passed CI tests

Objections:
  Jenkins CI: Failed CI tests



-- 
To view, visit https://gerrit.ovirt.org/68460
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I0cbfe7ae1a2b144577c37a77656a5b4a251075a6
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Arik Hadas <ahadas at redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Shahar Havivi <shavivi at redhat.com>
Gerrit-Reviewer: Shmuel Leib Melamud <smelamud at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>



More information about the Engine-commits mailing list