Change in ovirt-engine[master]: core: Remove useless call in DeactivateStorageDomainCommandTest

Code Review gerrit at ovirt.org
Tue Dec 27 13:04:35 UTC 2016


>From Tal Nisan <tnisan at redhat.com>:

Tal Nisan has submitted this change and it was merged.

Change subject: core: Remove useless call in DeactivateStorageDomainCommandTest
......................................................................


core: Remove useless call in DeactivateStorageDomainCommandTest

The call to setup() is redundant as the setup method is called before
every test as it's annotated with the @Before annotation

Change-Id: I1b5827883a488c01141d6bb43da45efeddca3b23
Signed-off-by: Tal Nisan <tnisan at redhat.com>
---
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/domain/DeactivateStorageDomainCommandTest.java
1 file changed, 0 insertions(+), 1 deletion(-)

Approvals:
  Tal Nisan: Verified
  Benny Zlotnik: Looks good to me, but someone else must approve
  Jenkins CI: Passed CI tests
  Allon Mureinik: Looks good to me, approved
  Idan Shaby: Looks good to me, but someone else must approve
  Ala Hino: Looks good to me, but someone else must approve



-- 
To view, visit https://gerrit.ovirt.org/68848
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I1b5827883a488c01141d6bb43da45efeddca3b23
Gerrit-PatchSet: 12
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Tal Nisan <tnisan at redhat.com>
Gerrit-Reviewer: Ala Hino <ahino at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Amit Aviram <aaviram at redhat.com>
Gerrit-Reviewer: Benny Zlotnik <bzlotnik at redhat.com>
Gerrit-Reviewer: Freddy Rolland <frolland at redhat.com>
Gerrit-Reviewer: Idan Shaby <ishaby at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Tal Nisan <tnisan at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>


More information about the Engine-commits mailing list