Change in ovirt-engine[master]: core: Extract master deactivation valid in DeactivateStorage...

Code Review gerrit at ovirt.org
Tue Dec 27 13:05:27 UTC 2016


>From Tal Nisan <tnisan at redhat.com>:

Tal Nisan has submitted this change and it was merged.

Change subject: core: Extract master deactivation valid in DeactivateStorageDomainCommand
......................................................................


core: Extract master deactivation valid in DeactivateStorageDomainCommand

Extract the master deactivation part in DeactivateStorageDomainCommand
the logic there became messy unified with the HE deactivation branch and
extracting it to a method makes it more readable

Change-Id: I6e0743fa05a2b07fb3f19a211b61e58375f61662
Signed-off-by: Tal Nisan <tnisan at redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/domain/DeactivateStorageDomainCommand.java
1 file changed, 25 insertions(+), 19 deletions(-)

Approvals:
  Tal Nisan: Verified; Passed CI tests
  Daniel Erez: Looks good to me, approved



-- 
To view, visit https://gerrit.ovirt.org/68921
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I6e0743fa05a2b07fb3f19a211b61e58375f61662
Gerrit-PatchSet: 10
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Tal Nisan <tnisan at redhat.com>
Gerrit-Reviewer: Ala Hino <ahino at redhat.com>
Gerrit-Reviewer: Amit Aviram <aaviram at redhat.com>
Gerrit-Reviewer: Benny Zlotnik <bzlotnik at redhat.com>
Gerrit-Reviewer: Daniel Erez <derez at redhat.com>
Gerrit-Reviewer: Freddy Rolland <frolland at redhat.com>
Gerrit-Reviewer: Idan Shaby <ishaby at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Liron Aravot <laravot at redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipchuk at redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>


More information about the Engine-commits mailing list