Change in ovirt-engine[master]: core: cdPathWindowsToLinux(String, String) empty check

Code Review gerrit at ovirt.org
Tue Dec 27 21:49:08 UTC 2016


>From Allon Mureinik <amureini at redhat.com>:

Allon Mureinik has submitted this change and it was merged.

Change subject: core: cdPathWindowsToLinux(String, String) empty check
......................................................................


core: cdPathWindowsToLinux(String, String) empty check

Cleaned up a redundant empty string check in this method. As it is
only called by cdPathWindowsToLinux(String, Guid, Guid), which
already checks for empty strings, there's no reason to check for empty
strings in this method too - there's just no way to reach it with an
empty string.

Change-Id: Ifbfd165c175dd96873e7aa8284c637a202ca58d3
Signed-off-by: Allon Mureinik <amureini at redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmCommand.java
1 file changed, 0 insertions(+), 3 deletions(-)

Approvals:
  Tal Nisan: Looks good to me, approved
  Jenkins CI: Passed CI tests
  Allon Mureinik: Verified
  Freddy Rolland: Looks good to me, but someone else must approve



-- 
To view, visit https://gerrit.ovirt.org/68372
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ifbfd165c175dd96873e7aa8284c637a202ca58d3
Gerrit-PatchSet: 6
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Freddy Rolland <frolland at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Betak <mbetak at redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>


More information about the Engine-commits mailing list