Change in ovirt-engine[master]: core: StorageConnectionHelperTest mocking

Code Review gerrit at ovirt.org
Thu Dec 29 10:45:06 UTC 2016


>From Allon Mureinik <amureini at redhat.com>:

Allon Mureinik has submitted this change and it was merged.

Change subject: core: StorageConnectionHelperTest mocking
......................................................................


core: StorageConnectionHelperTest mocking

StorageConnectionHelperTest#helper is initialized by the @Mock
annotation, and then overriden in the setup() method. Since this mock is
never used, the annotation can safely be removed.

Change-Id: I84ca1ad4bde182143b58073ae28d30a80f1c8cc1
Signed-off-by: Allon Mureinik <amureini at redhat.com>
---
M backend/manager/modules/vdsbroker/src/test/java/org/ovirt/engine/core/vdsbroker/storage/StorageConnectionHelperTest.java
1 file changed, 0 insertions(+), 1 deletion(-)

Approvals:
  Tal Nisan: Looks good to me, approved
  Jenkins CI: Passed CI tests
  Allon Mureinik: Verified



-- 
To view, visit https://gerrit.ovirt.org/69246
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I84ca1ad4bde182143b58073ae28d30a80f1c8cc1
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Tal Nisan <tnisan at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>


More information about the Engine-commits mailing list