Change in ovirt-engine[master]: core: AbstractPropertiesTestBase generics

amureini at redhat.com amureini at redhat.com
Mon Feb 1 12:14:12 UTC 2016


Allon Mureinik has submitted this change and it was merged.

Change subject: core: AbstractPropertiesTestBase generics
......................................................................


core: AbstractPropertiesTestBase generics

Made AbstractPropertiesTestBase use a generalized Class object instead
of a raw object to help future users avoid unsafe casts and annoying
workarounds.

Change-Id: I39f7fe63b1547e00e63f5f81d2c4251fc00db921
Signed-off-by: Allon Mureinik <amureini at redhat.com>
---
M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/EngineErrorsTest.java
M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/ErrorMessagesTest.java
M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dal/dbbroker/auditloghandling/AuditLogMessagesTest.java
M backend/manager/modules/utils/src/test/java/org/ovirt/engine/core/utils/AbstractPropertiesTestBase.java
M backend/manager/modules/utils/src/test/java/org/ovirt/engine/core/utils/EnumTranslationProperties.java
M frontend/webadmin/modules/userportal-gwtp/src/test/java/org/ovirt/engine/ui/userportal/EngineErrorsTest.java
M frontend/webadmin/modules/userportal-gwtp/src/test/java/org/ovirt/engine/ui/userportal/ErrorMessagesTest.java
M frontend/webadmin/modules/webadmin/src/test/java/org/ovirt/engine/ui/webadmin/EngineErrorsTest.java
M frontend/webadmin/modules/webadmin/src/test/java/org/ovirt/engine/ui/webadmin/ErrorMessagesTest.java
9 files changed, 13 insertions(+), 13 deletions(-)

Approvals:
  Allon Mureinik: Verified; Looks good to me, approved; Passed CI tests
  Idan Shaby: Looks good to me, but someone else must approve



-- 
To view, visit https://gerrit.ovirt.org/51370
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I39f7fe63b1547e00e63f5f81d2c4251fc00db921
Gerrit-PatchSet: 6
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Amit Aviram <aaviram at redhat.com>
Gerrit-Reviewer: Daniel Erez <derez at redhat.com>
Gerrit-Reviewer: Idan Shaby <ishaby at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Tal Nisan <tnisan at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>



More information about the Engine-commits mailing list