Change in ovirt-engine[master]: core: Remove TagsDirectorTest#testCloneTag()

amureini at redhat.com amureini at redhat.com
Mon Feb 8 10:26:06 UTC 2016


Allon Mureinik has submitted this change and it was merged.

Change subject: core: Remove TagsDirectorTest#testCloneTag()
......................................................................


core: Remove TagsDirectorTest#testCloneTag()

The Tags class has no special logic or implementation of cloning or
serializing. The testCloneTag() uses
apache.commons.collections.Trasformer to clone a Tags instance, but no
production code does this, meaning this is essentially a test for
apache, not oVirt Engine's code.

In short, this test is completely redundant, and hence this patch just
removes it.

Change-Id: I665e44aa1e004cbd9ffd66c1992d414187fea3fd
Signed-off-by: Allon Mureinik <amureini at redhat.com>
---
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/TagsDirectorTest.java
1 file changed, 0 insertions(+), 13 deletions(-)

Approvals:
  Allon Mureinik: Verified; Passed CI tests
  Moti Asayag: Looks good to me, approved



-- 
To view, visit https://gerrit.ovirt.org/53177
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I665e44aa1e004cbd9ffd66c1992d414187fea3fd
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Moti Asayag <masayag at redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>



More information about the Engine-commits mailing list