Change in ovirt-hosted-engine-setup[master]: networking: enforcing unique match between hostname and mgmt...

[sbonazzo at redhat.com]

Sandro Bonazzola has submitted this change and it was merged.

Change subject: networking: enforcing unique match between hostname and mgmt interface
......................................................................


networking: enforcing unique match between hostname and mgmt interface

hosted-engine-setup has to create the management bridge before
starting the engine VM otherwise it will have no connectivity.
Then it will trigger host-deploy calling hosts.add on the engine API
passing just an address parameter to identify the host;
the address should be the host name (cfg rhbz#1178535)
On host-deploy, VDSM will try to re-create the management bridge on the
interface where address resolves to. This can randomly lead to a wrong
network configuration if address can be resolved to more than one interface.
Enforcing unique match between address and the IP of the management
interface to avoid this.
This is compatible with the current version of oVirt node since it let the user
to configure just one interface and so there is no ambiguity by construction there
but it should be re.tested with node.next.

Change-Id: I478b499c6e1b3a6160822f4c58966c6d29f4e42d
Bug-Url: https://bugzilla.redhat.com/1291083
Signed-off-by: Simone Tiraboschi <stirabos at redhat.com>
---
M src/ovirt_hosted_engine_setup/constants.py
M src/plugins/ovirt-hosted-engine-setup/engine/add_host.py
M src/plugins/ovirt-hosted-engine-setup/network/bridge.py
M src/plugins/ovirt-hosted-engine-setup/vm/cloud_init.py
4 files changed, 58 insertions(+), 6 deletions(-)

Approvals:
  Sandro Bonazzola: Looks good to me, approved
  Simone Tiraboschi: Verified
  Jenkins CI: Passed CI tests



-- 
To view, visit https://gerrit.ovirt.org/53142
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I478b499c6e1b3a6160822f4c58966c6d29f4e42d
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-hosted-engine-setup
Gerrit-Branch: master
Gerrit-Owner: Simone Tiraboschi <stirabos at redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland at redhat.com>
Gerrit-Reviewer: Fabian Deutsch <fabiand at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Rafael Martins <rmartins at redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo at redhat.com>
Gerrit-Reviewer: Simone Tiraboschi <stirabos at redhat.com>
Gerrit-Reviewer: Yedidyah Bar David <didi at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>