Change in ovirt-engine[master]: core: Propagate lock state when running async commands via CoCo

masayag at redhat.com masayag at redhat.com
Thu Feb 11 20:24:49 UTC 2016


Moti Asayag has submitted this change and it was merged.

Change subject: core: Propagate lock state when running async commands via CoCo
......................................................................


core: Propagate lock state when running async commands via CoCo

A command may need to propagate acquired locks to executed child
commands, such as when AddDiskCommand calls AddImageFromScratchCommand.

For Image Upload, I had temporarily changed the above call to use the
Command Coordinator and discovered that the lock held by the parent
was not being passed to the child.

The root cause was the lock was being overwritten in CommandBase when
the execution context for the child was initialized.  To avoid this,
we now pass the lock defined in the Command instance to the context
inititialization method.

Change-Id: I8cab6aa4d8788703285fb43003995f7f9d7b4efb
Related-To: https://bugzilla.redhat.com/1091377
Signed-off-by: Greg Padgett <gpadgett at redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/Backend.java
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Greg Padgett: Verified
  Ravi Nori: Looks good to me, but someone else must approve
  Jenkins CI: Passed CI tests
  Moti Asayag: Looks good to me, approved



-- 
To view, visit https://gerrit.ovirt.org/53151
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I8cab6aa4d8788703285fb43003995f7f9d7b4efb
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Greg Padgett <gpadgett at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Amit Aviram <aaviram at redhat.com>
Gerrit-Reviewer: Daniel Erez <derez at redhat.com>
Gerrit-Reviewer: Greg Padgett <gpadgett at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Liron Aravot <laravot at redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipchuk at redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag at redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali at redhat.com>
Gerrit-Reviewer: Ravi Nori <rnori at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>



More information about the Engine-commits mailing list