Change in ovirt-engine[master]: core: LiveMerge - avoid unneeded endAction() run

laravot at redhat.com laravot at redhat.com
Tue Feb 16 16:58:32 UTC 2016


Liron Aravot has submitted this change and it was merged.

Change subject: core: LiveMerge - avoid unneeded endAction() run
......................................................................


core: LiveMerge - avoid unneeded endAction() run

When running the live merge flow, the endAction() of
RemoveSnapshotSingleDiskLiveCommand shouldn't run as currently
the logic is contained within the onFailed()/onSucceeded() methods
(that should be changed in a separate change).

Furthermore, in this change the end methods are overriden to clarify that
the logic in the parent command shouldn't be executed ever.

Change-Id: I562d07d713cba53c0ca1a2c2a14f05d65d98ab8d
Bug-Url: https://bugzilla.redhat.com/1306743
Signed-off-by: Liron Aravot <laravot at redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/snapshots/RemoveSnapshotCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/snapshots/RemoveSnapshotSingleDiskLiveCommand.java
2 files changed, 11 insertions(+), 0 deletions(-)

Approvals:
  Greg Padgett: Looks good to me, but someone else must approve
  Jenkins CI: Passed CI tests
  Daniel Erez: Looks good to me, approved
  Ala Hino: Looks good to me, but someone else must approve
  Liron Aravot: Verified



-- 
To view, visit https://gerrit.ovirt.org/53566
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I562d07d713cba53c0ca1a2c2a14f05d65d98ab8d
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Liron Aravot <laravot at redhat.com>
Gerrit-Reviewer: Ala Hino <ahino at redhat.com>
Gerrit-Reviewer: Daniel Erez <derez at redhat.com>
Gerrit-Reviewer: Greg Padgett <gpadgett at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Liron Aravot <laravot at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>



More information about the Engine-commits mailing list