Change in ovirt-engine[master]: restapi: Ensure that V4 delegates are always non-null

[juan.hernandez at redhat.com]

Juan Hernandez has submitted this change and it was merged.

Change subject: restapi: Ensure that V4 delegates are always non-null
......................................................................


restapi: Ensure that V4 delegates are always non-null

The V4 compatibility layer is composed by a set of server classes that
are almost empty, as they forward almost all the requests to the
corresponding V4 "delegates". The delegate is passed to the V4
constructor, and it is assumed to be always be non-null, but that isn't
explicitly checked. Some code coverage tools complain about the fact
that it can in theory be null. This patch adds an assertion to the
constructors, which will hoefully stop this complaining.

Change-Id: I7b1405a4856c9b4344f738864b3f18dfd5660da8
Signed-off-by: Juan Hernandez <juan.hernandez at redhat.com>
---
M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/v3/V3Server.java
1 file changed, 5 insertions(+), 0 deletions(-)

Approvals:
  Juan Hernandez: Verified; Looks good to me, approved
  Jenkins CI: Passed CI tests
  Allon Mureinik: Looks good to me, but someone else must approve



-- 
To view, visit https://gerrit.ovirt.org/54031
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I7b1405a4856c9b4344f738864b3f18dfd5660da8
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Juan Hernandez <juan.hernandez at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Juan Hernandez <juan.hernandez at redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>