Change in ovirt-engine[ovirt-engine-3.6.2]: engine: Introudce NetworkAttachmentIpConfigurationValidator

[tnisan at redhat.com]

Tal Nisan has submitted this change and it was merged.

Change subject: engine: Introudce NetworkAttachmentIpConfigurationValidator
......................................................................


engine: Introudce NetworkAttachmentIpConfigurationValidator

The validator will validate the network attachment's ip configuration.

A valid ip configuration must has a primary address with valid
boot protocol and ip details.
In case the boot protocol is static, ip details must contains ip
addres and netmask.  Please note that gateway is not mandatory
as the kernal can complete it with a default one.
For dhcp or none boot protocols, no ip details should be
mentioned.  In case of dhcp, the dhcp itself should determine
it.

Change-Id: I589013ef2b6783c77a424a8d21fad5da8a7f3250
Bug-Url: https://bugzilla.redhat.com/1270807
Signed-off-by: Eliraz Levi <elevi at redhat.com>
---
A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/network/NetworkAttachmentIpConfigurationValidator.java
A backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/validator/network/NetworkAttachmentIpConfigurationValidatorTest.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/EngineMessage.java
M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties
M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java
M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
6 files changed, 283 insertions(+), 1 deletion(-)

Approvals:
  Tal Nisan: Passed CI tests
  Eliraz Levi: Verified
  Alona Kaplan: Looks good to me, approved



-- 
To view, visit https://gerrit.ovirt.org/51237
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I589013ef2b6783c77a424a8d21fad5da8a7f3250
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.6.2
Gerrit-Owner: Eliraz Levi <elevi at redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan at redhat.com>
Gerrit-Reviewer: Eliraz Levi <elevi at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Tal Nisan <tnisan at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>