Change in ovirt-engine-cli[master]: cli: Generate remote viewer config using UTF-8

juan.hernandez at redhat.com juan.hernandez at redhat.com
Thu Jan 7 10:53:29 UTC 2016


Juan Hernandez has submitted this change and it was merged.

Change subject: cli: Generate remote viewer config using UTF-8
......................................................................


cli: Generate remote viewer config using UTF-8

Currently the CLI generates the remote-viewer configuration files using
the default encoding used by Python, which happens to be "ascii". One of
the pieces of information that is written to these files is the subject
of the certificate of the host. This is retrieved from the engine, and
it may contain characters that aren't part of the ASCII character set.
When this happens Python tries to encode text using the "ascii" codec,
and that generates an exception. To avoid that this patch changes the
CLI so that these configuration files are generated using an Unicode
template and encoding the result explicitly using the "utf-8" codec
instead of the default.

Change-Id: Ib85d5134da87f7d901f4a7ff3bedfb7d7a3af628
Bug-Url: https://bugzilla.redhat.com/807696
Signed-off-by: Juan Hernandez <juan.hernandez at redhat.com>
---
M src/ovirtcli/platform/posix/spice.py
M src/ovirtcli/platform/posix/vnc.py
2 files changed, 4 insertions(+), 4 deletions(-)

Approvals:
  Juan Hernandez: Verified; Looks good to me, approved; Passed CI tests



-- 
To view, visit https://gerrit.ovirt.org/51404
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ib85d5134da87f7d901f4a7ff3bedfb7d7a3af628
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine-cli
Gerrit-Branch: master
Gerrit-Owner: Juan Hernandez <juan.hernandez at redhat.com>
Gerrit-Reviewer: Juan Hernandez <juan.hernandez at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>



More information about the Engine-commits mailing list